> On July 17, 2018, 11:16 a.m., Andrew Schwartzmeyer wrote: > > include/mesos/docker/spec.hpp > > Lines 124-126 (patched) > > <https://reviews.apache.org/r/67931/diff/1/?file=2059702#file2059702line124> > > > > I think this and the commit before need to be re-ordered, as this > > commit is introducing logic required and used by the previous commit.
I think you fixed this? > On July 17, 2018, 11:16 a.m., Andrew Schwartzmeyer wrote: > > include/mesos/docker/spec.hpp > > Lines 141 (patched) > > <https://reviews.apache.org/r/67931/diff/1/?file=2059702#file2059702line141> > > > > Dumb question, but is there an S1/S2 for V1 as well? > > Liangyu Zhao wrote: > I don't think so. There is, but it's not in use, so I'll drop this. > On July 17, 2018, 11:16 a.m., Andrew Schwartzmeyer wrote: > > include/mesos/docker/spec.hpp > > Lines 141-164 (patched) > > <https://reviews.apache.org/r/67931/diff/1/?file=2059702#file2059702line141> > > > > I'm not sure, but would this be better as a variant? > > > > ``` > > std::unique_ptr<Variant<v1::ImageManifest, v2::ImageManifest, > > v2_2::ImageManifest>> manifest; > > ``` > > > > (Declared at point of use.) > > > > P.S. Why do we need pointers? > > Liangyu Zhao wrote: > I haven't used the `std::Variant` before. I think it is a better choice. > > The reason why I used pointers is trying to avoid copying the object. > This is just a minor optimization of efficiency. Avoid pointers whenever possible; the minor optimization isn't worth the potential bug cost. Plus with move semantics the optimization probably won't even matter. > On July 17, 2018, 11:16 a.m., Andrew Schwartzmeyer wrote: > > src/uri/fetcher.cpp > > Lines 88 (patched) > > <https://reviews.apache.org/r/67931/diff/1/?file=2059712#file2059712line90> > > > > Why does this function throw away `urls`? > > Liangyu Zhao wrote: > This is just a default parent class function. Currently, only > `DockerFetcherPulgin` supports multiple URLs fetch, so it overrides this > function. As for other plugins, this is the default way of handling extra > URLs. Commented at `include\mesos\uri\fetcher.hpp` line 89. Gotcha. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67931/#review206157 ----------------------------------------------------------- On July 18, 2018, 2:27 a.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67931/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 2:27 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Support parsing schema 2 and fetching blob with multiple URLs as > specified in schema 2. Update `curl` version to 7.61.0 because of bug > encountered in version 7.57.0. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f > 3rdparty/cmake/Versions.cmake 0a897d808cd9e05ac0d1a4e1ca61b8f3538f0c4a > include/mesos/docker/spec.hpp 2879414dc42ffe633ac74b51e1bb116698c41162 > include/mesos/docker/v2_2.hpp PRE-CREATION > include/mesos/docker/v2_2.proto PRE-CREATION > include/mesos/uri/fetcher.hpp 760d6b33234d8efdc533c0c6f05e83a5c7d1f56b > src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 > src/Makefile.am 228e168c22f3fd0367f029c506171c6979b31c07 > src/docker/spec.cpp 96fbf1f9cf1c2c4b2383607a97990f3a9156e6d9 > src/slave/containerizer/mesos/containerizer.cpp > 98129d006cda9b65804b518619b6addc8990410a > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 > src/uri/fetcher.hpp fbf64c6767dea3aa0798f68db8322ce47cd8ad36 > src/uri/fetcher.cpp 489c7ce0198ee6803dcc8eb9710b292fa743a0e8 > src/uri/fetchers/docker.hpp cdbab9a5684a68a729be12bc06d331acca137da5 > src/uri/fetchers/docker.cpp 55ca118660872a933a2dc186723bec6a39ee80f7 > > > Diff: https://reviews.apache.org/r/67931/diff/3/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > >
