----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67826/ -----------------------------------------------------------
(Updated July 17, 2018, 12:47 p.m.) Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Changes ------- +yanxu Re BenM: - Updated the description regarding motivation. - Documented the shared resource allocation strategy. - This patch is self-contained -- it preserves the code correctness. - No, it does not affect the current metrics in any way. Repository: mesos Description (updated) ------- Currently, depending on already allocated resources, `HierarchicalAllocatorProcess::Slave::getAvailable()` may not contain all the shared resources. Thus it does not accurately reflect what is available. Since shared resources are always allocatable, we should include all shared resources in the agent available resources. This would help remove the one off logic for removing and adding back shared resources in the allocation loop. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 Diff: https://reviews.apache.org/r/67826/diff/2/ Changes: https://reviews.apache.org/r/67826/diff/1-2/ Testing ------- make check Thanks, Meng Zhu
