----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67826/#review206479 -----------------------------------------------------------
Ship it! I'll take care of these prior to committing to avoid another round trip! src/master/allocator/mesos/hierarchical.hpp Lines 377-382 (original), 377-388 (patched) <https://reviews.apache.org/r/67826/#comment289458> I noticed this is missing the optimization comment, but can't we just call updateAvailable()? src/master/allocator/mesos/hierarchical.hpp Lines 382 (patched) <https://reviews.apache.org/r/67826/#comment289457> Looks like this can be in the initializer list? - Benjamin Mahler On July 24, 2018, 7:50 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67826/ > ----------------------------------------------------------- > > (Updated July 24, 2018, 7:50 p.m.) > > > Review request for mesos, Benjamin Mahler and Jiang Yan Xu. > > > Bugs: MESOS-9104 > https://issues.apache.org/jira/browse/MESOS-9104 > > > Repository: mesos > > > Description > ------- > > Currently, depending on already allocated resources, > `HierarchicalAllocatorProcess::Slave::getAvailable()` > may not contain all the shared resources. > Thus it does not accurately reflect what is available. > > Since shared resources are always allocatable, we should > include all shared resources in the agent available resources. > This would help remove the one off logic for removing and > adding back shared resources in the allocation loop. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > c1a6789f1808a57dd94ede7bbd2636031f136ea3 > > > Diff: https://reviews.apache.org/r/67826/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
