> On July 30, 2018, 5:30 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > > Line 381 (original), 388 (patched) > > <https://reviews.apache.org/r/67932/diff/3/?file=2061482#file2061482line388> > > > > Did we change behavior here? This is in a loop, so the original code > > was constantly adding to the front, whereas now we're adding the back (IMHO > > original code smells a bit funny). > > Liangyu Zhao wrote: > Nope, in line 469, I reverse the vector. It's just not cool to > continuously add stuff at front in vector.
Ah, I see. Can you update the location of the comment above now? I agree, it's not cool to always prepend to a vector. > On July 30, 2018, 5:30 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > > Lines 379-380 (patched) > > <https://reviews.apache.org/r/67932/diff/3/?file=2061483#file2061483line379> > > > > I take it that the `wclayer` command in `wclayer_remove` is supposed to > > remove the directory? > > Liangyu Zhao wrote: > Yeah, there is some privilege issues that `rmdir` does not work here. To > remove the directory, we have to use `wclayer`. That's fine; please add a comment though to explain the discrepancy with the Linux code. > On July 30, 2018, 5:30 p.m., Andrew Schwartzmeyer wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > > Lines 490 (patched) > > <https://reviews.apache.org/r/67932/diff/3/?file=2061483#file2061483line490> > > > > Last I remember, `flags.docker_store_dir` was some Linux path; did we > > get that fixed (or am I misremembering)? > > Liangyu Zhao wrote: > I believe it has already been fixed. I have run the agent and log this. > It turns out to be a Windows path. Yup, looks like it: `path::join(os::temp(), "mesos", "store", "docker")`. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206625 ----------------------------------------------------------- On July 18, 2018, 2:27 a.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67932/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 2:27 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The `tar` command cannot work successfully on Windows, so use `wclayer` > instead. Note that the folder generated from extraction also cannot be > deleted by `rmdir`, so the GC is also changed to use `wclayer remove`. > > > Diffs > ----- > > src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc > src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 85aad25ac8ecfda125be85fb46d882c3982f3930 > > > Diff: https://reviews.apache.org/r/67932/diff/3/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > >
