----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206693 -----------------------------------------------------------
Ship it! I'll clean up for Mesos whitespace/formatting/commenting etc., but otherwise LGTM. - Andrew Schwartzmeyer On July 31, 2018, 2:41 p.m., Liangyu Zhao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67932/ > ----------------------------------------------------------- > > (Updated July 31, 2018, 2:41 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The `tar` command cannot work successfully on Windows, so use `wclayer` > instead. Note that the folder generated from extraction also cannot be > deleted by `rmdir`, so the GC is also changed to use `wclayer remove`. > > > Diffs > ----- > > src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc > src/common/command_utils.cpp 7dfcc9ff74bcf044d47b803ebc42cf63fba89d17 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > a5683e3fe15dd35596122fcc0c580ae9d3adf7f2 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 85aad25ac8ecfda125be85fb46d882c3982f3930 > > > Diff: https://reviews.apache.org/r/67932/diff/4/ > > > Testing > ------- > > > Thanks, > > Liangyu Zhao > >
