----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/#review206891 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/statistics.hpp Line 80 (original), 80-82 (patched) <https://reviews.apache.org/r/68225/#comment290015> Do you want a TODO to expose these in metrics snapshots? E.g. ``` T p25; // TODO(alexr): Expose this in metrics snapshots. T p75; // TODO(alexr): Expose this in metrics snapshots. ``` Or just expose them in this patch? 3rdparty/libprocess/src/tests/statistics_tests.cpp Lines 93-94 (original), 95-98 (patched) <https://reviews.apache.org/r/68225/#comment290016> We should probably have a test that maps p25 to 25, pXX to XX, etc to be more obviously correct. But certainly no need to touch it in this patch. - Benjamin Mahler On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68225/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2018, 10:30 a.m.) > > > Review request for mesos, Benno Evers and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/statistics.hpp > e9f1fc23bf83f92a2e7de94dba0df48272cc3394 > 3rdparty/libprocess/src/tests/statistics_tests.cpp > a2a780bf9de018c823b68aa48977fd9fd1b8a064 > > > Diff: https://reviews.apache.org/r/68225/diff/1/ > > > Testing > ------- > > https://reviews.apache.org/r/68132/ > > > Thanks, > > Alexander Rukletsov > >
