> On Aug. 6, 2018, 5:57 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/statistics.hpp > > Line 80 (original), 80-82 (patched) > > <https://reviews.apache.org/r/68225/diff/1/?file=2068401#file2068401line80> > > > > Do you want a TODO to expose these in metrics snapshots? E.g. > > > > ``` > > T p25; // TODO(alexr): Expose this in metrics snapshots. > > T p75; // TODO(alexr): Expose this in metrics snapshots. > > ``` > > > > Or just expose them in this patch?
Added a TODO in "libprocess/src/metrics/metrics.cpp". - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68225/#review206891 ----------------------------------------------------------- On Aug. 9, 2018, 2:21 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68225/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2018, 2:21 p.m.) > > > Review request for mesos, Benno Evers and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/statistics.hpp > e9f1fc23bf83f92a2e7de94dba0df48272cc3394 > 3rdparty/libprocess/src/metrics/metrics.cpp > ba1962fa1aa96fa4153b95b7a5562ba46ab28b3b > 3rdparty/libprocess/src/tests/statistics_tests.cpp > a2a780bf9de018c823b68aa48977fd9fd1b8a064 > > > Diff: https://reviews.apache.org/r/68225/diff/2/ > > > Testing > ------- > > https://reviews.apache.org/r/68132/ > > > Thanks, > > Alexander Rukletsov > >
