----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/ -----------------------------------------------------------
Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu. Repository: mesos Description ------- WIP: Tests with `default:id`. Not for merging. Diffs ----- src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1 Diff: https://reviews.apache.org/r/68301/diff/1/ Testing ------- This should have _almost_ all the tests pass, except for: ``` [ FAILED ] 9 tests, listed below: [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos" ``` Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest. Thanks, Andrew Schwartzmeyer
