----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/ -----------------------------------------------------------
(Updated Aug. 17, 2018, 6:19 p.m.) Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu. Summary (updated) ----------------- Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`. Repository: mesos Description (updated) ------- By adding a `:` to the default executor ID used by the tests, this thoroughly exercises MESOS-9109. Diffs (updated) ----- src/tests/containerizer/volume_host_path_isolator_tests.cpp 81bf72e869d36edb162b121f9e84a53d2096dae3 src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421 src/tests/health_check_tests.cpp 7544b2c20cb271655ad41c5d8f71739c26e6c638 src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 src/tests/slave_authorization_tests.cpp 061e230b52805c4260e93ac83734aed5454ea3b5 src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1 src/tests/upgrade_tests.cpp de3911c77f9e40398672889cf43c25d36a6fb274 Diff: https://reviews.apache.org/r/68301/diff/3/ Changes: https://reviews.apache.org/r/68301/diff/2-3/ Testing ------- This should have _almost_ all the tests pass, except for: ``` [ FAILED ] 9 tests, listed below: [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "mesos" [ FAILED ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0, where GetParam() = "docker,mesos" [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "docker,mesos" ``` Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via regedit + manifest. Thanks, Andrew Schwartzmeyer
