----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67960/#review207228 -----------------------------------------------------------
I like the idea of having handling time statistics per endpoint. What I think would be also useful is to match response time with a particular request. For example, for an "umbrella" endpoint like "/v1/api", the response time can vary significantly based on the supplied `Call` message. Something as simple as https://github.com/rukletsov/mesos/commit/02efaa9e66c5fb34f624334817e2c915c5344d16 can help with this. Maybe we should have both? 3rdparty/libprocess/src/process.cpp Line 4002 (original), 4047 (patched) <https://reviews.apache.org/r/67960/#comment290540> remove this please. 3rdparty/libprocess/src/process.cpp Line 4027 (original), 4091 (patched) <https://reviews.apache.org/r/67960/#comment290541> Same here. 3rdparty/libprocess/src/tests/http_tests.cpp Lines 99-109 (original) <https://reviews.apache.org/r/67960/#comment290542> Doesn't it belong to https://reviews.apache.org/r/67958/ ? - Alexander Rukletsov On July 18, 2018, 1:28 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67960/ > ----------------------------------------------------------- > > (Updated July 18, 2018, 1:28 a.m.) > > > Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Added support for instrumenting HTTP endpoints. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > 7c255acc21c695eba37062a3dcf72ce33f650cd0 > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 23d7aee963b6fb489403a94500d39e3413c7fcdd > 3rdparty/libprocess/src/process.cpp > 7c0a0bc0c1e50354b6da219032ac830cbeec0a0d > 3rdparty/libprocess/src/tests/http_tests.cpp > acbd6973829411652fc5d57ef473c0d8ba9cd5b4 > > > Diff: https://reviews.apache.org/r/67960/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
