----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review207277 -----------------------------------------------------------
include/mesos/agent/agent.proto Lines 100 (patched) <https://reviews.apache.org/r/68147/#comment290610> Would `MARK_RESOURCE_PROVIDER_GONE` be a more consistent (w.r.t. the `MARK_AGENT_GONE` master API) and less confusing name? - Chun-Hung Hsiao On Aug. 1, 2018, 3:47 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68147/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2018, 3:47 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > This patch adds support for triggering permanent removal of local > resource providers. We also add authorization and tests as part of this > patch. > > > Diffs > ----- > > include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 > include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f21593444467c66ed35ee90aea07f > src/slave/http.hpp dcfd0d9831775912942afb746ce6704383868468 > src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 > src/slave/slave.hpp 802d4eb9e9eba2f1175dd85e56dcc80a61e32f74 > src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591 > src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e > src/tests/api_tests.cpp 9c9fa9105a27ac7bb7f30d7eb67512d1e1d63d15 > > > Diff: https://reviews.apache.org/r/68147/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >