----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review207450 -----------------------------------------------------------
src/slave/slave.cpp Lines 7934 (patched) <https://reviews.apache.org/r/68147/#comment290851> This line combined with Line 8079 will crash the agent. - Chun-Hung Hsiao On Aug. 16, 2018, 2:31 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68147/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2018, 2:31 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > This patch adds support for triggering permanent removal of local > resource providers. We also add authorization and tests as part of this > patch. > > > Diffs > ----- > > include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 > include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f21593444467c66ed35ee90aea07f > src/slave/http.hpp 78200874cb03a3d5af4ee0443c03a1d94cd494cc > src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 > src/slave/slave.hpp 802d4eb9e9eba2f1175dd85e56dcc80a61e32f74 > src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c > src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e > src/tests/api_tests.cpp 9c9fa9105a27ac7bb7f30d7eb67512d1e1d63d15 > > > Diff: https://reviews.apache.org/r/68147/diff/5/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
