----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68360/#review207360 -----------------------------------------------------------
Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot On Aug. 15, 2018, 12:04 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68360/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2018, 12:04 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > After creation on an `ObjectApprovers` instance, the principal > is only required for providing meaningful log messages. > > This commit encodes that at the type system by storing the principal > as a string as opposed to a `Principal` object. > > > Diffs > ----- > > src/common/http.hpp 0901a5528b3c383e3e391a3ac1571fd0fd544998 > > > Diff: https://reviews.apache.org/r/68360/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
