----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68360/#review207582 -----------------------------------------------------------
Patch looks great! Reviews applied: [68360] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 17, 2018, 7:02 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68360/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 7:02 p.m.) > > > Review request for mesos, Alexander Rukletsov and Alexander Rojas. > > > Repository: mesos > > > Description > ------- > > After creation on an `ObjectApprovers` instance, the principal > is only required for providing meaningful log messages. > > This commit encodes that at the type system by storing the principal > as a string as opposed to a `Principal` object. > > > Diffs > ----- > > src/common/http.hpp 0901a5528b3c383e3e391a3ac1571fd0fd544998 > > > Diff: https://reviews.apache.org/r/68360/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
