> On Aug. 16, 2018, 3:51 p.m., Benjamin Mahler wrote: > > src/tests/authentication_tests.cpp > > Lines 415 (patched) > > <https://reviews.apache.org/r/68354/diff/4/?file=2073674#file2073674line415> > > > > Why the underscores?
Removed. > On Aug. 16, 2018, 3:51 p.m., Benjamin Mahler wrote: > > src/tests/authentication_tests.cpp > > Lines 475-484 (patched) > > <https://reviews.apache.org/r/68354/diff/4/?file=2073674#file2073674line475> > > > > Have you considered using an array of expected values? This would also > > let us loop over those expected values in a bounded way? E.g. > > > > ``` > > slaveFlags.authentication_timeout_min = 5 > > slaveFlags.authentication_timeout_max = 60 > > slaveFlags.authentication_timeout_factor = 2 > > > > expected = [ > > [5, 5+2^1] > > [5, 5+2^2] > > ... > > [5, 60] > > [5, 60] > > ] > > > > ``` > > > > Seems more readable? Good point! Done. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68354/#review207444 ----------------------------------------------------------- On Aug. 16, 2018, 4:54 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68354/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2018, 4:54 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > This test verifies that the agent backs-off properly when > retrying authentication according to the configured parameters. > > Also mocked `Slave::authenticate()` for this test. > > > Diffs > ----- > > src/slave/slave.hpp 0420109ac93e1249906c52437e5859c5ee033fb6 > src/tests/authentication_tests.cpp f7a2cf17cf6154c9c67e405661bba57cf1254845 > src/tests/mock_slave.hpp 9a74bf35d2cab0a72ba6376392239d8080a49304 > src/tests/mock_slave.cpp 94a5b0d20475f49dde99108a009682b520175aa4 > > > Diff: https://reviews.apache.org/r/68354/diff/5/ > > > Testing > ------- > > make check > > Added test continuously running without failure. > > > Thanks, > > Meng Zhu > >
