----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63280/#review207546 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On Aug. 17, 2018, 11:14 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63280/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 11:14 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Benjamin > Mahler, Gilbert Song, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8128 > https://issues.apache.org/jira/browse/MESOS-8128 > > > Repository: mesos > > > Description > ------- > > Since the containerizer launch depends on the inherited pipe to signal > the forked child, be explicit about manipulating O_CLOEXEC on the pipe > file descriptors. Make sure to close the pipe on the error paths. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 98129d006cda9b65804b518619b6addc8990410a > src/slave/containerizer/mesos/launcher.cpp > ed41a14892bdfa74d28bd0541ca188b86f8f96f8 > src/slave/containerizer/mesos/linux_launcher.cpp > d1f8d3f56a9ef3aa98012c9395e74732e49c264d > > > Diff: https://reviews.apache.org/r/63280/diff/4/ > > > Testing > ------- > > sudo make check (Fedora 28) > > > Thanks, > > James Peach > >
