----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68147/#review207982 -----------------------------------------------------------
Patch looks great! Reviews applied: [68407, 68143, 68144, 68146, 68362, 68145, 68147] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 20, 2018, 6:47 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68147/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2018, 6:47 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan > Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > This patch adds support for triggering permanent removal of local > resource providers. We also add authorization and tests as part of this > patch. > > > Diffs > ----- > > include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 > include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f21593444467c66ed35ee90aea07f > src/slave/http.hpp 78200874cb03a3d5af4ee0443c03a1d94cd494cc > src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 > src/slave/slave.hpp b1d695b59a63a5af34b19faff16bf6c82b7e7d88 > src/slave/slave.cpp e6c7e686f287fb4448a0074d4e99298665fc866d > src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e > src/tests/api_tests.cpp ee82350f7a6c6d44ba0590608e7d9a223c0be169 > > > Diff: https://reviews.apache.org/r/68147/diff/8/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >