> On Aug. 6, 2018, 9:49 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 759-768 (original), 757-759 (patched) > > <https://reviews.apache.org/r/68134/diff/1/?file=2065614#file2065614line759> > > > > Probably an explanation to the reader is warranted on why we do this?
I was thinking that a more suitable place for such a comment would be the callsite of `removeFilters()`, and it turns out we do already have one there: https://github.com/apache/mesos/blob/7ad23b87626c215703118c74602f53ce2d12cc59/src/master/allocator/mesos/hierarchical.cpp#L655-L663 I'm going to drop this issue for now, LMK if you think the linked comment is insufficient. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68134/#review206913 ----------------------------------------------------------- On July 31, 2018, 6:57 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68134/ > ----------------------------------------------------------- > > (Updated July 31, 2018, 6:57 p.m.) > > > Review request for mesos, Benno Evers and Benjamin Mahler. > > > Bugs: MESOS-9124 > https://issues.apache.org/jira/browse/MESOS-9124 > > > Repository: mesos > > > Description > ------- > > When agent reconfiguration was enabled in Mesos, the allocator was > also updated to remove all offer filters associated with an agent when > that agent's attributes change. In addition, whenever filters for an > agent are removed, the framework is revived for all roles that it is > registered in. > > While this ensures that schedulers will have an opportunity to use > resources on an agent after reconfiguration, modifying the scheduler's > suppression may put the scheduler in an inconsistent state, where it > believes it is suppressed in a particular role when it is not. > > This patch eliminates the suppression modification code, while > keeping the code which removes a reconfigured agent's offer filters. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 35992474eacb8b14ae57e1dc23307e1542f63cb5 > > > Diff: https://reviews.apache.org/r/68134/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
