> On Sept. 11, 2018, 11 a.m., Till Toenshoff wrote: > > 3rdparty/stout/tests/os/filesystem_tests.cpp > > Line 817 (original), 817 (patched) > > <https://reviews.apache.org/r/68679/diff/1/?file=2087695#file2087695line817> > > > > According to the BSD manpages, `statvfs` does not have a member called > > `f_fsize`. See https://www.unix.com/man-page/osx/3/statvfs/ > > > > My compiler says the same: > > ``` > > ../../../3rdparty/stout/tests/os/filesystem_tests.cpp:817:30: error: no > > member named 'f_fsize' in 'statvfs' > > EXPECT_EQ(used.get() / b.f_fsize, b.f_blocks - b.f_bfree); > > ~ ^ > > ``` > > > > This is what the header contains: > > ``` > > /* Following structure is used as a statvfs/fstatvfs function parameter > > */ > > struct statvfs { > > unsigned long f_bsize; /* File system block size */ > > unsigned long f_frsize; /* Fundamental file system > > block size */ > > fsblkcnt_t f_blocks; /* Blocks on FS in units of > > f_frsize */ > > fsblkcnt_t f_bfree; /* Free blocks */ > > fsblkcnt_t f_bavail; /* Blocks available to non-root > > */ > > fsfilcnt_t f_files; /* Total inodes */ > > fsfilcnt_t f_ffree; /* Free inodes */ > > fsfilcnt_t f_favail; /* Free inodes for non-root */ > > unsigned long f_fsid; /* Filesystem ID */ > > unsigned long f_flag; /* Bit mask of values */ > > unsigned long f_namemax; /* Max file name length */ > > }; > > ```
I mess it up when I transferred the diff from my macOS host to my Linux host :( - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68679/#review208511 ----------------------------------------------------------- On Sept. 10, 2018, 11:18 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68679/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2018, 11:18 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9214 > https://issues.apache.org/jira/browse/MESOS-9214 > > > Repository: mesos > > > Description > ------- > > The `f_bsize` elemement denotes the preferred filesystem block > size, not the unit that `f_blocks` is counting in. We need to > use `f_frsize` for that. > > > Diffs > ----- > > 3rdparty/stout/tests/os/filesystem_tests.cpp > be15395fc38f7b106ddcd886ba426197f2e783d1 > > > Diff: https://reviews.apache.org/r/68679/diff/2/ > > > Testing > ------- > > Ran stout tests on macOS 10.13.2 > > > Thanks, > > James Peach > >
