----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68679/#review208849 -----------------------------------------------------------
Ship it! Thanks so much James for staying on this ball. Giving it a final CI run and then landing it. 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 818-823 (original) <https://reviews.apache.org/r/68679/#comment293084> Seems indeed we can not get the /dev space check to support older ubuntu and centos versions without bigger hoops. - Till Toenshoff On Sept. 18, 2018, 5:46 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68679/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2018, 5:46 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9214 > https://issues.apache.org/jira/browse/MESOS-9214 > > > Repository: mesos > > > Description > ------- > > The `f_bsize` elemement denotes the preferred filesystem block > size, not the unit that `f_blocks` is counting in. We need to > use `f_frsize` for that. > > Remove the check for used space on `/dev` since that is not even > portable across different Linux distributions. > > > Diffs > ----- > > 3rdparty/stout/tests/os/filesystem_tests.cpp > be15395fc38f7b106ddcd886ba426197f2e783d1 > > > Diff: https://reviews.apache.org/r/68679/diff/4/ > > > Testing > ------- > > Ran stout tests on macOS 10.13.2, Fedora 28, Centos 6.9 and Ubuntu 14.04. > > > Thanks, > > James Peach > >
