----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/#review208531 -----------------------------------------------------------
3rdparty/Makefile.am Lines 327 (patched) <https://reviews.apache.org/r/68640/#comment292528> I think that `JEMALLOC_CONFIGURE_ARGS` is a typo? It reads more clearly to me if you just put the extra options inline: ``` ./configure $(CONFIGURE_ARGS) \ --disable-dependency-tracking \ --disable-debug-mode \ --disable-samples \ ... ``` configure.ac Lines 1616 (patched) <https://reviews.apache.org/r/68640/#comment292527> At this point, you know the latest version that is acceptable. I think that you could do a `AC_RUN_IFELSE` to compare that version using `event_get_version_number`. That would remove the need to manually run the compiler. configure.ac Lines 1635 (patched) <https://reviews.apache.org/r/68640/#comment292523> Can you make this whole version check logic a separate autoconf macro? I think that would make configure.ac easier to follow and also make it easier to duplicate in libprocess. ``` MESOS_CHECK_LIBEVENT_IS_USABLE( action-if-usable, action-if-not-usable ) ``` - James Peach On Sept. 6, 2018, 10:07 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68640/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2018, 10:07 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach. > > > Bugs: MESOS-7076 > https://issues.apache.org/jira/browse/MESOS-7076 > > > Repository: mesos > > > Description > ------- > > Bundles libevent 2.0.22 to ensure functional SSL builds accross all > supported platforms. Namely macOS and Ubuntu have shown problems when > using more recent libevent versions. The underlying problem has been > under investigation for a longer period of time - so far without a > solution. The bundled libevent includes a patch to make it libssl > version > 1.0.x compatible. That patch has been extracted from the > Fedora source package libevent-2.0.22-6.fc27. The resulting libevent > builds against both, libssl 1.0.x as well as libssl 1.1.x. > For unbundled builds a version detection of known problematic > distributions vs. provided libevent is included. > > > Diffs > ----- > > 3rdparty/Makefile.am a6709ff9c7ef81896174ed4d35e1b1da9bb33757 > 3rdparty/libevent-2.0.22-stable.patch PRE-CREATION > 3rdparty/libevent-2.0.22-stable.tar.gz PRE-CREATION > 3rdparty/versions.am 8fd8bd4d7482af5304ab0b56270e49f447e0b3f5 > configure.ac 9de51e59796e2a64138acb82cbbb080f1ae6cc6e > src/python/native_common/ext_modules.py.in > 7efbb8ec91b74c32ac629f1f2e7de82986d518db > > > Diff: https://reviews.apache.org/r/68640/diff/2/ > > > Testing > ------- > > Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. Additional testing > is ongoing. CMake updates will follow. > > > Thanks, > > Till Toenshoff > >
