----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68700/#review208564 -----------------------------------------------------------
Fix it, then Ship it! support/docker-build.sh Lines 50 (patched) <https://reviews.apache.org/r/68700/#comment292614> We don't seem to do the cleanup part here. This is likely okay since the created image is throw-away anyway. support/docker-build.sh Lines 86-91 (patched) <https://reviews.apache.org/r/68700/#comment292615> What is the reason you put this only for 16.04? I have the feeling that we should do this for more versions so that e.g., ubuntu-14.04 or ubuntu-18.04 also work out of the box, i.e., move it out of the case. Same comment regarding cleanup steps which can be removed. - Benjamin Bannier On Sept. 12, 2018, 3:31 p.m., Robin Gögge wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68700/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2018, 3:31 p.m.) > > > Review request for mesos, Armand Grillet and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Updated support/docker-build.sh to install Python 3.6. > > > Diffs > ----- > > support/docker-build.sh 435413ab3433e3f8628bdf5ca7a750cb5ff5c22b > > > Diff: https://reviews.apache.org/r/68700/diff/1/ > > > Testing > ------- > > Created docker images for each OS (centos, ubuntu-16.04) and successfully ran > `support/mesos-style.py` with `python3`. > > > Thanks, > > Robin Gögge > >
