> On Sept. 12, 2018, 4:59 p.m., Benjamin Bannier wrote: > > support/docker-build.sh > > Lines 86-91 (patched) > > <https://reviews.apache.org/r/68700/diff/1/?file=2088573#file2088573line86> > > > > What is the reason you put this only for 16.04? > > I have the feeling that we should do this for more versions so that > > e.g., ubuntu-14.04 or ubuntu-18.04 also work out of the box, i.e., move it > > out of the case. > > > > Same comment regarding cleanup steps which can be removed. > > Robin Gögge wrote: > So I dont really know about ubuntu-14.04, but for ubuntu-18.04 python3 > installation is much simpler since there will be no need to add additional > ppa's.
Okay, let's not worry about anything but 16.04 then. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68700/#review208564 ----------------------------------------------------------- On Sept. 12, 2018, 3:31 p.m., Robin Gögge wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68700/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2018, 3:31 p.m.) > > > Review request for mesos, Armand Grillet and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Updated support/docker-build.sh to install Python 3.6. > > > Diffs > ----- > > support/docker-build.sh 435413ab3433e3f8628bdf5ca7a750cb5ff5c22b > > > Diff: https://reviews.apache.org/r/68700/diff/1/ > > > Testing > ------- > > Created docker images for each OS (centos, ubuntu-16.04) and successfully ran > `support/mesos-style.py` with `python3`. > > > Thanks, > > Robin Gögge > >
