----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68731/ -----------------------------------------------------------
(Updated Sept. 18, 2018, 9:20 p.m.) Review request for mesos, Gastón Kleiman and Meng Zhu. Changes ------- Updated the random sorter as well. Summary (updated) ----------------- Added a ScalarResourceQuantities type to improve sorters performance. Bugs: MESOS-9239 https://issues.apache.org/jira/browse/MESOS-9239 Repository: mesos Description ------- This type replaces the use of hashmaps keyed by resource names in favor of storing vectors of `pair<string,Value::Scalar>`, in order to avoid the performance penalty of using hashmaps. Running *HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/21 shows the following improvement: Using 10000 agents and 1000 frameworks Added 1000 frameworks in 42.49ms -> 42.85ms (no change) Added 10000 agents in 7.69secs -> 4.89secs (normalized: 1 -> 0.64) round 0 allocate() took 5.42secs -> 3.53secs (nomralized: 1 -> 0.65) Diffs (updated) ----- src/master/allocator/sorter/drf/sorter.hpp 5a4fa5e2dca61168923261230b1f5c245354cbb7 src/master/allocator/sorter/random/sorter.hpp 7f6c0de70e3ae03d7362fb9e140b93435e530499 src/master/allocator/sorter/sorter.hpp 432ccfe24ed2854df9cc186a8691009cbdb763c7 Diff: https://reviews.apache.org/r/68731/diff/2/ Changes: https://reviews.apache.org/r/68731/diff/1-2/ Testing ------- make check Thanks, Benjamin Mahler