----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68731/#review208908 -----------------------------------------------------------
src/master/allocator/sorter/sorter.hpp Lines 177-180 (patched) <https://reviews.apache.org/r/68731/#comment293187> we can use `find_if` to make it more concise and readable. I will leave that to you. Ditto for `::at`. src/master/allocator/sorter/sorter.hpp Lines 204-207 (patched) <https://reviews.apache.org/r/68731/#comment293185> Comments need to be updated regarding "first-class resource". src/master/allocator/sorter/sorter.hpp Lines 219-222 (patched) <https://reviews.apache.org/r/68731/#comment293186> we should be able to do: ``` return quantities.insert(it, std::make_pair(name, Value::Scalar()))->second; ``` Furthur, we can replace the `break` above with this. - Meng Zhu On Sept. 21, 2018, 4:24 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68731/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2018, 4:24 p.m.) > > > Review request for mesos, Gastón Kleiman and Meng Zhu. > > > Bugs: MESOS-9239 > https://issues.apache.org/jira/browse/MESOS-9239 > > > Repository: mesos > > > Description > ------- > > This type replaces the use of hashmaps keyed by resource names in > favor of storing vectors of `pair<string,Value::Scalar>`, in order > to avoid the performance penalty of using hashmaps. > > Running *HierarchicalAllocator_BENCHMARK_Test.DeclineOffers/21 shows > the following improvement: > > Using 10000 agents and 1000 frameworks > Added 1000 frameworks in 42.49ms -> 42.85ms (no change) > Added 10000 agents in 7.69secs -> 4.89secs (normalized: 1 -> 0.64) > round 0 allocate() took 5.42secs -> 3.53secs (nomralized: 1 -> 0.65) > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.hpp > 71352c848e812b7c499dfbf0f09dc86fac3ee8e1 > src/master/allocator/sorter/random/sorter.hpp > 6bfeda0f0d02b4738a6d46a7798b1bf4751f0b38 > src/master/allocator/sorter/sorter.hpp > 432ccfe24ed2854df9cc186a8691009cbdb763c7 > > > Diff: https://reviews.apache.org/r/68731/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
