----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68756/#review208841 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Bannier On Sept. 19, 2018, 8:36 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68756/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2018, 8:36 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-9228 > https://issues.apache.org/jira/browse/MESOS-9228 > > > Repository: mesos > > > Description > ------- > > Each type of RP might have some specific validations for RP info. For > example, SLRP requires the `storage` field to be set. This patch makes > the local RP daemon to perform such validations when adding/updating > configs, so the `ADD_RESOURCE_PROVIDER_CONFIG` and > `UPDATE_RESOURCE_PROVIDER_CONFIG` calls can fail fast. > > > Diffs > ----- > > src/resource_provider/daemon.cpp 0a76cc6d1d34413674d1af1aa514679a4d2b7b55 > src/resource_provider/local.hpp 20bcc78d3fe847e03526fa59116bdbac92ec1e29 > src/resource_provider/local.cpp 801e6c430ed91315d87f8a45b8f3ed128beca4fc > src/resource_provider/storage/provider.hpp > 5a371b19289c6e39fedd4cda65fa8be432d095e6 > src/resource_provider/storage/provider.cpp > 6475f653263337c381b6080695d09c49e5ea8fcf > src/slave/http.cpp f8199af50cf0b43bbbb8c29afe751fcd8949d7e8 > > > Diff: https://reviews.apache.org/r/68756/diff/2/ > > > Testing > ------- > > make check > > New tests added later in the chain. > > > Thanks, > > Chun-Hung Hsiao > >
