> On Nov. 8, 2017, 1:48 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/socket.hpp > > Lines 74 (patched) > > <https://reviews.apache.org/r/63654/diff/1/?file=1884313#file1884313line74> > > > > I am not sure such a function is useful in general; maybe consider > > adding it just as a lambda into `socketpair`. > > James Peach wrote: > It is used in [r/63655](https://reviews.apache.org/r/63655/). It's > occasionally convenient.
Removed the helper. > On Nov. 8, 2017, 1:48 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/os/posix/socket.hpp > > Lines 131-132 (patched) > > <https://reviews.apache.org/r/63654/diff/1/?file=1884313#file1884313line131> > > > > Does it make sense to include this setup into this function? This > > function does not invoke `send`. > > James Peach wrote: > This is for consistency with > [os::socket](https://github.com/apache/mesos/blob/master/3rdparty/stout/include/stout/os/socket.hpp#L31). Updated the coment. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63654/#review190444 ----------------------------------------------------------- On Nov. 8, 2017, 1:12 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63654/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 1:12 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8156 > https://issues.apache.org/jira/browse/MESOS-8156 > > > Repository: mesos > > > Description > ------- > > Added a `net::socketpair` helper to stout that deals with > automatically setting O_CLOEXEC and disabling SIGPIPE where > necessary. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/socket.hpp > bab0b808f53abd1314a7d13fc0cba75e5717f96f > 3rdparty/stout/tests/os/sendfile_tests.cpp > 05966ae067ae3972598da3370eb16fdce5736c21 > > > Diff: https://reviews.apache.org/r/63654/diff/3/ > > > Testing > ------- > > make check (Fedora 26, macOS) > > > Thanks, > > James Peach > >
