----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63654/#review209599 -----------------------------------------------------------
Ship it! Ship It! - Gilbert Song On Oct. 1, 2018, 10:36 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63654/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2018, 10:36 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-8156 > https://issues.apache.org/jira/browse/MESOS-8156 > > > Repository: mesos > > > Description > ------- > > Added a `net::socketpair` helper to stout that deals with > automatically setting O_CLOEXEC and disabling SIGPIPE where > necessary. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/socket.hpp > 5557394e9ce8e4addc07d328d55274a9d573dfcd > 3rdparty/stout/tests/os/sendfile_tests.cpp > e334f489756e6f3352e7b1e84aabb9d40b734138 > > > Diff: https://reviews.apache.org/r/63654/diff/4/ > > > Testing > ------- > > make check (Fedora 26, macOS) > > > Thanks, > > James Peach > >