----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68090/#review209664 -----------------------------------------------------------
src/master/flags.cpp Lines 124-128 (patched) <https://reviews.apache.org/r/68090/#comment294212> Seems like we should clarify that this flag is a workaround of a leveldb bug and that it's temporary? Or are you thinking this should be permanent? - Benjamin Mahler On July 27, 2018, 8:12 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68090/ > ----------------------------------------------------------- > > (Updated July 27, 2018, 8:12 p.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Bugs: MESOS-184 > https://issues.apache.org/jira/browse/MESOS-184 > > > Repository: mesos > > > Description > ------- > > The new flag enables experimental automatic compaction invocation for > the LevelDB based replicated log storage. This is a workaround the > problem described in for MESOS-184. > > > Diffs > ----- > > src/master/flags.hpp 3929c297b45e1203e5b00454e88f86988a8b1058 > src/master/flags.cpp 8fede0d2cf2254f34134329885f47c3c78dc5846 > src/master/main.cpp 2c7b1bb492a0655dec9280e98ff942a15e2ae8f0 > > > Diff: https://reviews.apache.org/r/68090/diff/1/ > > > Testing > ------- > > Ran `make check`. Manually verified that the replicated log storage doesn't > grow over time with `--log_auto_compact=true`. > > > Thanks, > > Ilya Pronin > >