----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69068/ -----------------------------------------------------------
(Updated Oct. 17, 2018, 6:14 p.m.) Review request for mesos, Benjamin Mahler and Gastón Kleiman. Summary (updated) ----------------- Cached whether agents have gpus to improve allocator performance. Repository: mesos Description ------- Due to the `filterGpuResources` mechanism, before making any allocations, the allocator needs to check if an agent has any GPU resources. This is currently done by calling the `Resources::gpus()` function which traverse the resource vector and copy the scalar. Since this is frequently called and agent total resources rarely change, caching this boolean will yield quite some performance improvement. Diffs (updated) ----- src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5 src/master/allocator/mesos/hierarchical.cpp 6f389ed46683f7c642e87b673dc15307cc2b5cd6 Diff: https://reviews.apache.org/r/69068/diff/2/ Changes: https://reviews.apache.org/r/69068/diff/1-2/ Testing ------- make check Thanks, Meng Zhu
