----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69068/#review209728 -----------------------------------------------------------
Patch looks great! Reviews applied: [68507, 69068] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 18, 2018, 1:14 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69068/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2018, 1:14 a.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Repository: mesos > > > Description > ------- > > Due to the `filterGpuResources` mechanism, before making any > allocations, the allocator needs to check if an agent has > any GPU resources. This is currently done by calling the > `Resources::gpus()` function which traverse the resource > vector and copy the scalar. Since this is frequently called > and agent total resources rarely change, caching this boolean > will yield quite some performance improvement. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > e09a615979014909e7b88d44e6617fd1476415c5 > src/master/allocator/mesos/hierarchical.cpp > 6f389ed46683f7c642e87b673dc15307cc2b5cd6 > > > Diff: https://reviews.apache.org/r/69068/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
