----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68642/#review209786 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/os/posix/lsof.hpp Lines 36 (patched) <https://reviews.apache.org/r/68642/#comment294382> Close `fdDir` here. - James Peach On Oct. 19, 2018, 6:57 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68642/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2018, 6:57 a.m.) > > > Review request for mesos, Gilbert Song and James Peach. > > > Bugs: MESOS-9152 > https://issues.apache.org/jira/browse/MESOS-9152 > > > Repository: mesos > > > Description > ------- > > Added `lsof()` into stout. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am a9c61fcba253a811494cdcdb0afb3d3a018f4585 > 3rdparty/stout/include/stout/os.hpp > aee041891b7e7ff93a0b1ac31019a7a3d4eae962 > 3rdparty/stout/include/stout/os/lsof.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/posix/lsof.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/lsof.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/68642/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
