> On Oct. 23, 2018, 2:54 p.m., Vinod Kone wrote: > > src/linux/cgroups.cpp > > Line 1124 (original), 1137 (patched) > > <https://reviews.apache.org/r/69123/diff/1/?file=2101988#file2101988line1137> > > > > Didn't quite follow why you had make this an Option?
If the Listener is terminated without listen() being called, the `reading` future was never assigned and remains pending forever. In this case, we can't wait for it. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/#review209921 ----------------------------------------------------------- On Oct. 23, 2018, 3:08 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69123/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2018, 3:08 a.m.) > > > Review request for mesos and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > The cgroups event notifier was closing the eventfd while an > `io::read()` operation may be in progress. This can lead to > bugs where the fd gets re-used and read from a stale io::read. > > > Diffs > ----- > > src/linux/cgroups.cpp 95efc1def3318dd93d30d91e9c8a91376cc610b8 > > > Diff: https://reviews.apache.org/r/69123/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
