> On Oct. 25, 2018, 4:07 p.m., Qian Zhang wrote: > > Not yours, I see in `MemorySubsystemProcess::oomListen` we have the these > > code: > > ``` > > info->oomNotifier.onReady( > > defer(PID<MemorySubsystemProcess>(this), > > &MemorySubsystemProcess::oomWaited, > > containerId, > > cgroup, > > lambda::_1)); > > ``` > > Here the `onReady` seems not correct to me, I think it should be `onAny`. > > Benjamin Mahler wrote: > Hm.. ok, this warrants a separate patch, do you want to send one?
Posted one: https://reviews.apache.org/r/69188/ - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69123/#review210024 ----------------------------------------------------------- On Oct. 26, 2018, 11:25 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69123/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2018, 11:25 a.m.) > > > Review request for mesos and Qian Zhang. > > > Bugs: MESOS-9334 > https://issues.apache.org/jira/browse/MESOS-9334 > > > Repository: mesos > > > Description > ------- > > The cgroups event notifier was closing the eventfd while an > `io::read()` operation may be in progress. This can lead to > bugs where the fd gets re-used and read from a stale io::read. > > > Diffs > ----- > > src/linux/cgroups.cpp 95efc1def3318dd93d30d91e9c8a91376cc610b8 > > > Diff: https://reviews.apache.org/r/69123/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
