----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69188/#review210104 -----------------------------------------------------------
Ship it! Perhaps a little more description would be helpful? E.g. ``` Ensured failed / discarded cgroup oom notification is logged. Failed or discarded oom notificaitions in the cgroup memory isolator were not being logged, due to the continuation being accidentally set up using onReady rather than onAny. ``` This tells the user what functionally is changing (they will now see logging if it fails or is discarded). - Benjamin Mahler On Oct. 26, 2018, 3:26 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69188/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2018, 3:26 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9334 > https://issues.apache.org/jira/browse/MESOS-9334 > > > Repository: mesos > > > Description > ------- > > Fixed a wrong way to install callback for OOM notifier. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > f4ed8337253995250cb533fa0a232909cb1a824b > > > Diff: https://reviews.apache.org/r/69188/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
