----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69188/#review210137 -----------------------------------------------------------
Patch looks great! Reviews applied: [69123, 69188] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 29, 2018, 4:11 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69188/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2018, 4:11 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-9334 > https://issues.apache.org/jira/browse/MESOS-9334 > > > Repository: mesos > > > Description > ------- > > Failed or discarded OOM notificaitions in the cgroups memory > subsystem were not being logged, due to the continuation being > accidentally set up using `onReady` rather than `onAny`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > f4ed8337253995250cb533fa0a232909cb1a824b > > > Diff: https://reviews.apache.org/r/69188/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
