----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210246 -----------------------------------------------------------
Patch looks great! Reviews applied: [69116] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 22, 2018, 12:23 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69116/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2018, 12:23 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > ------- > > This code was pulled directly from: > https://github.com/dcos/dcos-core-cli/blob/ > 7fd55421939a7782c237e2b8719c0fe2f543acd7/ > python/lib/dcoscli/dcoscli/test/common.py > > This function will be used by tests requiring a TTY. This will be the > case for tests concerning the 'task attach' subcommand. > > > Diffs > ----- > > src/python/cli_new/lib/cli/tests/base.py > 7fd39af665164eeef8bb1359de340ef923dc2272 > > > Diff: https://reviews.apache.org/r/69116/diff/2/ > > > Testing > ------- > > > Thanks, > > Armand Grillet > >