----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210299 -----------------------------------------------------------
Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 12:23 nachm., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69116/ > ----------------------------------------------------------- > > (Updated Okt. 22, 2018, 12:23 nachm.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-9343 > https://issues.apache.org/jira/browse/MESOS-9343 > > > Repository: mesos > > > Description > ------- > > This code was pulled directly from: > https://github.com/dcos/dcos-core-cli/blob/ > 7fd55421939a7782c237e2b8719c0fe2f543acd7/ > python/lib/dcoscli/dcoscli/test/common.py > > This function will be used by tests requiring a TTY. This will be the > case for tests concerning the 'task attach' subcommand. > > > Diffs > ----- > > src/python/cli_new/lib/cli/tests/base.py > 7fd39af665164eeef8bb1359de340ef923dc2272 > > > Diff: https://reviews.apache.org/r/69116/diff/3/ > > > Testing > ------- > > ``` > (mesos-cli) ? cli_new (exec-attach) ? mesos-cli-tests > Running the Mesos CLI unit tests > > TestAgentPlugin > test_list (cli.tests.agent.TestAgentPlugin) ... ok > > TestInfrastructure > test_capture_output (cli.tests.tests.TestInfrastructure) ... ok > test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok > > TestTaskPlugin > test_exec (cli.tests.task.TestTaskPlugin) ... ok > test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok > test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok > test_list (cli.tests.task.TestTaskPlugin) ... ok > > ---------------------------------------------------------------------- > Ran 7 tests in 17.238s > > OK > ``` > > > Thanks, > > Armand Grillet > >
