----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210383 -----------------------------------------------------------
src/tests/slave_recovery_tests.cpp Line 4739 (original), 4742 (patched) <https://reviews.apache.org/r/69273/#comment295046> Now that the clock is paused, we should deterministically not get extra offers. You can probably remove these blocks from the test. Here and throughout the test. src/tests/slave_recovery_tests.cpp Line 4827 (original), 4841-4845 (patched) <https://reviews.apache.org/r/69273/#comment295045> There is always a non-zero delay between the agent's startup and subscribing to the master: https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1306-L1321 There isn't a great way to wait for the agent to detect the master, and then advance the clock. Instead, try setting `slaveFlags.registration_backoff_factor = Seconds(0);`. I think that should bypass this small subscription delay. - Joseph Wu On Nov. 7, 2018, 10:40 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69273/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2018, 10:40 a.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9358 > https://issues.apache.org/jira/browse/MESOS-9358 > > > Repository: mesos > > > Description > ------- > > Removed some flakyness from the test > SlaveRecoveryTest.AgentReconfigurationWithRunningTask > by removing the `refuse_offers` filter and by pausing > the clock whenever possible during the test. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 5842ccffaf8c409aaa9c84720ba6c7b07ba6dc7c > > > Diff: https://reviews.apache.org/r/69273/diff/1/ > > > Testing > ------- > > `./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" > --gtest_repeat=200` > > > Thanks, > > Benno Evers > >
