----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69273/#review210559 -----------------------------------------------------------
Ship it! src/tests/slave_recovery_tests.cpp Lines 4822 (patched) <https://reviews.apache.org/r/69273/#comment295263> I'm going to add your note on this line as a comment before committing: ``` // Remove the registration delay to circumvent a delay in the recovery // logic. This will allow the agent to register with the master after // detecting the master, even when the clock is paused. ``` - Joseph Wu On Nov. 14, 2018, 7:23 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69273/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2018, 7:23 a.m.) > > > Review request for mesos, Greg Mann and Joseph Wu. > > > Bugs: MESOS-9358 > https://issues.apache.org/jira/browse/MESOS-9358 > > > Repository: mesos > > > Description > ------- > > Removed some flakyness from the test > SlaveRecoveryTest.AgentReconfigurationWithRunningTask > by removing the `refuse_offers` filter and by pausing > the clock whenever possible during the test. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 0fef5aa0b61004571b241b50b69b06f4404405ac > > > Diff: https://reviews.apache.org/r/69273/diff/3/ > > > Testing > ------- > > `./src/mesos-tests --gtest_filter="*ReconfigurationWithRunning*" > --gtest_repeat=500` > > > Thanks, > > Benno Evers > >
