> On Nov. 2, 2018, 10:23 p.m., Benjamin Mahler wrote: > > Hm.. why is this one not just extending the one you added in the previous > > review? > > Meng Zhu wrote: > This benchmark compares quota vs. non-quota. For non-quota setting, there > will be no chopping. So for fair comparison, quota setting should have no > chopping either. The previous test focuses quota only and chopping is an > important part of it.
Ok, can you spell it out a bit more in the comments and description, it just seems to say the same allocations are made, but would be good to explain how that was done and why other benchmarks might fail to do it? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69098/#review210294 ----------------------------------------------------------- On Oct. 22, 2018, 10:39 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69098/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2018, 10:39 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Bugs: MESOS-6630 > https://issues.apache.org/jira/browse/MESOS-6630 > > > Repository: mesos > > > Description > ------- > > This benchmark evaluates the performance difference between nonquota > and quota settings. In both settings, the same allocations are made > for fair comparison. > > > Diffs > ----- > > src/tests/hierarchical_allocator_benchmarks.cpp > bf9167b63747f7b8a402d950947028436307082a > > > Diff: https://reviews.apache.org/r/69098/diff/1/ > > > Testing > ------- > > Result from optimized build on a multicore 2.2GHz machine: > > Benchmark setup: 20 agents, 10 roles, 20 frameworks > Made 20 allocations in 3.508676ms for nonquota roles > Made 20 allocations in 7.901269ms for quota roles > > Benchmark setup: 200 agents, 100 roles, 200 frameworks > Made 200 allocations in 63.407391ms for nonquota roles > Made 200 allocations in 279.002319ms for quota roles > > Benchmark setup: 2000 agents, 1000 roles, 2000 frameworks > Made 2000 allocations in 4.003802373secs for nonquota roles > Made 2000 allocations in 20.503188535secs for quota roles > > > Thanks, > > Meng Zhu > >
