> On Dec. 5, 2018, 4:49 p.m., Greg Mann wrote: > > src/executor/executor.cpp > > Lines 797 (patched) > > <https://reviews.apache.org/r/69473/diff/2/?file=2112292#file2112292line797> > > > > Can we break `Minutes(30)` out into a common header somewhere so we can > > use it in the test as well? If we don't do this now, let's leave a TODO for > > that as well.
I've opted for the TODO, since we don't have a good header for executor constants right now. There are a few other constants and flags for executors which we could potentially put into a header somewhere. But we can discuss/do that in future. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review211070 ----------------------------------------------------------- On Dec. 5, 2018, 5:24 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69473/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2018, 5:24 p.m.) > > > Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. > > > Bugs: MESOS-7564 > https://issues.apache.org/jira/browse/MESOS-7564 > > > Repository: mesos > > > Description > ------- > > This implements two separate heartbeaters for Executor Events (agent > to executor) and Executor Calls (executor to agent). Both are set to > non-configurable intervals of 30 minutes, which should be sufficient > to keep the connections alive while not flooding logs with warnings > if the executor/agent does not have this patch. > > > Diffs > ----- > > src/common/validation.cpp 5f8f2889f79f9486f8bb731b39f706908dcd84ea > src/executor/executor.cpp d00ea32f02c1d92d64525b8b5ce5ca18ac840c1b > src/launcher/default_executor.cpp b89b0363d64b8dd8936a62b57803f0eff50bfc71 > src/launcher/executor.cpp 6b1204dc5a67d4fc3e8ceae378262d53f3d28421 > src/slave/constants.hpp fdc21a35bcc0028dc0a2d7ebd06171fad2a20ba1 > src/slave/http.cpp ba389263ef7ab311682d542424eb56360841d24c > src/slave/slave.hpp edf7269d4057ec8c95bb54c855210ad00d002a50 > src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb > > > Diff: https://reviews.apache.org/r/69473/diff/3/ > > > Testing > ------- > > make > > > Thanks, > > Joseph Wu > >
