----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/ -----------------------------------------------------------
(Updated Dec. 10, 2018, 5:20 p.m.) Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann. Changes ------- Moved the 30 Minute executor heartbeat interval into a constant. This is an `extern` so that the test can define and use it too, without a header. Bugs: MESOS-7564 https://issues.apache.org/jira/browse/MESOS-7564 Repository: mesos Description ------- This implements two separate heartbeaters for Executor Events (agent to executor) and Executor Calls (executor to agent). Both are set to non-configurable intervals of 30 minutes, which should be sufficient to keep the connections alive while not flooding logs with warnings if the executor/agent does not have this patch. Diffs (updated) ----- src/common/validation.cpp 5f8f2889f79f9486f8bb731b39f706908dcd84ea src/executor/executor.cpp d00ea32f02c1d92d64525b8b5ce5ca18ac840c1b src/executor/v0_v1executor.cpp aebdbe705dac604da44aba484dc4d007e83b8e37 src/launcher/default_executor.cpp b89b0363d64b8dd8936a62b57803f0eff50bfc71 src/launcher/executor.cpp 6b1204dc5a67d4fc3e8ceae378262d53f3d28421 src/slave/constants.hpp fdc21a35bcc0028dc0a2d7ebd06171fad2a20ba1 src/slave/http.cpp ba389263ef7ab311682d542424eb56360841d24c src/slave/slave.hpp edf7269d4057ec8c95bb54c855210ad00d002a50 src/slave/slave.cpp e13b955ffd92a8872dd513c006e96bd72e298c85 Diff: https://reviews.apache.org/r/69473/diff/5/ Changes: https://reviews.apache.org/r/69473/diff/4-5/ Testing ------- make Thanks, Joseph Wu