----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69516/#review211105 -----------------------------------------------------------
PASS: Mesos patch 69516 was successfully built and tested. Reviews applied: `['69516']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2680/mesos-review-69516 - Mesos Reviewbot Windows On Dec. 6, 2018, 3:54 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69516/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2018, 3:54 p.m.) > > > Review request for mesos, Benjamin Mahler and Gastón Kleiman. > > > Bugs: MESOS-7971 > https://issues.apache.org/jira/browse/MESOS-7971 > > > Repository: mesos > > > Description > ------- > > The test is flaky due to the race between agent processing > operations and master sending out offers. > > The test expects the offer to be sent out after the reserve > and create operations have finished. But it only waits for > the 202 returned by both calls. > > This patch adds manual clock control and uses `Clock::settle()` > to ensure calls are processed before proceeding. > > > Diffs > ----- > > src/tests/persistent_volume_endpoints_tests.cpp > 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7 > > > Diff: https://reviews.apache.org/r/69516/diff/1/ > > > Testing > ------- > > make check > ran continuously without failing > > > Thanks, > > Meng Zhu > >
