----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69551/#review211195 -----------------------------------------------------------
PASS: Mesos patch 69551 was successfully built and tested. Reviews applied: `['69551']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2696/mesos-review-69551 - Mesos Reviewbot Windows On Dec. 11, 2018, 1:20 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69551/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2018, 1:20 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Renamed `mesos::internal::tests::Metrics` to > `mesos::internal::tests::getMetricsSnapshot` to conform to our style guide, > and make it more clear to the reader that code like > > auto metrics = Metrics() > > is indeed a function call and not an instantiation of a class called > `Metrics`. > > > Diffs > ----- > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp 250ead9a9 > src/tests/containerizer/mesos_containerizer_tests.cpp 449928c10 > src/tests/fetcher_cache_tests.cpp 8766ffe25 > src/tests/fetcher_tests.cpp 90bee40f8 > src/tests/gc_tests.cpp a583f1d79 > src/tests/hierarchical_allocator_tests.cpp a3a6d7bb9 > src/tests/log_tests.cpp a8980e367 > src/tests/master_authorization_tests.cpp f65b6210a > src/tests/master_quota_tests.cpp 354a9e988 > src/tests/master_slave_reconciliation_tests.cpp de6e382ed > src/tests/master_tests.cpp 3bff7a13b > src/tests/oversubscription_tests.cpp edb95867c > src/tests/partition_tests.cpp 15af47b7d > src/tests/persistent_volume_tests.cpp 6afc56cec > src/tests/rate_limiting_tests.cpp 1946a6c10 > src/tests/resource_provider_manager_tests.cpp b61c50f83 > src/tests/scheduler_tests.cpp b571bb1d2 > src/tests/slave_recovery_tests.cpp 5ee64a400 > src/tests/slave_tests.cpp 1e918712d > src/tests/storage_local_resource_provider_tests.cpp 422a15204 > src/tests/utils.hpp b2f22cd4d > src/tests/utils.cpp 06d3d6214 > > > Diff: https://reviews.apache.org/r/69551/diff/1/ > > > Testing > ------- > > (todo) > > > Thanks, > > Benno Evers > >
