> On Dec. 7, 2018, 3:18 a.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8228 (patched) > > <https://reviews.apache.org/r/69337/diff/1/?file=2107897#file2107897line8228> > > > > It seems to me that we should remove the disappeared resources even if > > there is no resource provider reported, otherwise if the operator manually > > deleted the resource provider configs, we will see the stale resources > > forever.
We need to branch here as `UpdateSlaveMessage` has overloaded meanings. We only want to update resource provider information if the agent sent us resource provider information (the agent ensures to it sets this field -- possible to an empty set -- whenever it send RP information); wouldn't want to trigger RP GC for updates to oversubscribed resources. > On Dec. 7, 2018, 3:18 a.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8260 (patched) > > <https://reviews.apache.org/r/69337/diff/1/?file=2107897#file2107897line8260> > > > > Can you explain why we need to use this `resourceProvider` temporary > > variable here, given that `total_resources` is empty? You are right, this should not be here. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/#review211104 ----------------------------------------------------------- On Dec. 13, 2018, 2:51 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69337/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2018, 2:51 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-9384 > https://issues.apache.org/jira/browse/MESOS-9384 > > > Repository: mesos > > > Description > ------- > > The master previously kept information on resource providers > indefinitely. This was confusing to API users who saw resource > providers reported which where not present anymore, and also made it > harder to derive actual cluster state. > > With this patch we remove resource providers not reported by the agent > from master state. We still need to update the agent to not report > removed resource providers in a follow-up patch. > > > Diffs > ----- > > src/master/master.cpp 3de0fd35cc815f4b5787ee2cb5e81f5059d7a47c > > > Diff: https://reviews.apache.org/r/69337/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
