> On Dec. 14, 2018, 8:07 p.m., Chun-Hung Hsiao wrote: > > src/master/master.cpp > > Lines 8208 (patched) > > <https://reviews.apache.org/r/69337/diff/3/?file=2114080#file2114080line8208> > > > > Does it make sense to move this line before L8016
I am not sure what you have in mind. It seems that performing this removal earlier makes the code look scarier than it is -- we'd e.g., expect readers to understand that in the current loop around l.8016, we do not touch RPs which hadn't been removed in some GC step. Please clarify or drop. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/#review211339 ----------------------------------------------------------- On Dec. 14, 2018, 4:56 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69337/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2018, 4:56 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-9384 > https://issues.apache.org/jira/browse/MESOS-9384 > > > Repository: mesos > > > Description > ------- > > The master previously kept information on resource providers > indefinitely. This was confusing to API users who saw resource > providers reported which where not present anymore, and also made it > harder to derive actual cluster state. > > With this patch we remove resource providers not reported by the agent > from master state. We still need to update the agent to not report > removed resource providers in a follow-up patch. > > > Diffs > ----- > > src/master/master.cpp 3de0fd35cc815f4b5787ee2cb5e81f5059d7a47c > src/messages/messages.proto 41e6a8a2eab0ae7c2878c1d3286c5dea0eb68ed7 > > > Diff: https://reviews.apache.org/r/69337/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
