> On Dec. 13, 2018, 9:58 p.m., Vinod Kone wrote: > > git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > Failed command: git reset --hard > > b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > > > Error: b'fatal: Cannot do hard reset with paths.\n' > > > > > > This looks bad? Looks like we need to strip the trailing "\n"?
Thanks for the review, this is fixed and I have updated the `Testing Done`. - Armand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211306 ----------------------------------------------------------- On Dec. 13, 2018, 4:59 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69559/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2018, 4:59 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Dragos Schebesch, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-9459 > https://issues.apache.org/jira/browse/MESOS-9459 > > > Repository: mesos > > > Description > ------- > > We have switched the Python 2 support scripts to Python 3 a few months > ago. During this transition, 'verify-reviews.py' has been modified, > mainly to work better on Windows: https://reviews.apache.org/r/67505/. > > The Python 3 script has then replaced the Python 2 one and we now face > an issue with the script, MESOS-9459. Due to all the changes made > between the Python 2 and Python 3 scripts, it is hard for us to > know when the script started failing and why. > > To solve this issue, this commit takes the state of 'verify-reviews.py' > as it was in 74121798f24fca372180b8c4bc00b4df07d46240, applies 2to3, > adds the '--out-file' option, then adds the content of: > * ac766c8bd0fba348399d8eac52f75f62e64db64e > * 43eba285cb5c8622a6be8a5bdad637ed53431e85 > * 5b348b6070f0d0403cb69b6a7fa638fc46b7ff49 > * 568fcdfd29788d9df89a51ffae7969c2bf0ea173 > > This gives a clean diff between 74121798f24fca372180b8c4bc00b4df07d46240 > and this commit, fixes the issue raised in MESOS-9459, and does not > remove existing features. However, this uses less our common library > developed in the chain that landed while migrating from Python 2 to 3. > > This should be followed by a refactoring of 'verify-review.py' and > 'common.py' to use our library more while not breaking the script > when using Reviewbot. > > > Diffs > ----- > > support/verify-reviews.py 552dc366a588e6c5ad0efdcdca03d66f1d7044c3 > > > Diff: https://reviews.apache.org/r/69559/diff/2/ > > > Testing > ------- > > Checked https://www.diffchecker.com/R5uYlefc a diff of 'verify-reviews.py' > between 74121798f24fca372180b8c4bc00b4df07d46240 and this commit. > > > ``` > ? apache-mesos (MESOS-9459) ? BUILD_URL=yolo python3 > support/verify-reviews.py -u user -p password > git rev-parse HEAD > Checking if review: 69342 needs verification > Skipping blocking review 69342 > Checking if review: 69478 needs verification > Skipping blocking review 69478 > Checking if review: 69479 needs verification > Skipping blocking review 69479 > Checking if review: 67997 needs verification > Skipping blocking review 67997 > Checking if review: 68162 needs verification > Skipping blocking review 68162 > Checking if review: 68163 needs verification > Skipping blocking review 68163 > Checking if review: 69547 needs verification > Latest diff timestamp: 2018-12-11 12:15:07 > Verifying review 69547 > Posting review: Bad review! > > Reviews applied: [] > > Error: > No reviewers specified. Please find a reviewer by asking on JIRA or the > mailing list. > git clean -fd > git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > Failed command: git reset --hard b'69296553d96ca78b3145b9dd400a3c2332b441c7\n' > > Error: b'fatal: Cannot do hard reset with paths.\n' > Checking if review: 69557 needs verification > Latest diff timestamp: 2018-12-12 11:16:24 > Verifying review 69557 > Dependent review: https://reviews.apache.org/api/review-requests/69398/ > Dependent review: https://reviews.apache.org/api/review-requests/69397/ > Applying review 69397 > /usr/local/opt/python/bin/python3.7 support/apply-reviews.py -n -r 69397 > ``` > > > Thanks, > > Armand Grillet > >
