----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69571/#review211353 -----------------------------------------------------------
src/master/master.cpp Line 4758 (original), 4758 (patched) <https://reviews.apache.org/r/69571/#comment296355> I don't see how this is an improvement over using `std::deque`. We still need to iterate over these elements and IMO using a queue for this is a good fit. src/master/master.cpp Lines 5513-5519 (patched) <https://reviews.apache.org/r/69571/#comment296356> To keep the flow of checking for `error.isSome()`, let's not set `reason` in the block above but instead do it here and have: ``` if (error.isSome()) { reason = TaskStatus::REASON_TASK_GROUP_UNAUTHORIZED; } else { error = validation::task::group::validate( taskGroup, executor, framework, slave, _offeredResources); if (error.isSome()) { reason = TaskStatus::REASON_TASK_GROUP_INVALID; } } ``` - Jan Schlicht On Dec. 17, 2018, 7:29 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69571/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2018, 7:29 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff. > > > Bugs: MESOS-9480 > https://issues.apache.org/jira/browse/MESOS-9480 > > > Repository: mesos > > > Description > ------- > > This patch fixes a bug where the master does not complete the processing > of authorization results for `LAUNCH_GROUP`, causing a subsequent > operation to drop if one of the remaining authorization is denied. > > > Diffs > ----- > > src/master/master.cpp 3de0fd35cc815f4b5787ee2cb5e81f5059d7a47c > > > Diff: https://reviews.apache.org/r/69571/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
