> On Dec. 19, 2018, 12:48 a.m., Till Toenshoff wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > > Lines 1307-1308 (original) > > <https://reviews.apache.org/r/69590/diff/1/?file=2114813#file2114813line1309> > > > > Are we assuming that this location was never meant for users? > > Deepak Goel wrote: > Didn't understand your comment? Which location you are talking about? > > Chun-Hung Hsiao wrote: > I guess Till was asking why the log of `networkConfigJSON` is hidden from > user-facing logs (`LOG(INFO)`), unlike the other log lines.
Got it. networkConfigJSON might get big and could quickly fill up the log space. Hence, kept it at VLOG level just for debugging purpose. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69590/#review211416 ----------------------------------------------------------- On Dec. 19, 2018, 4:52 a.m., Deepak Goel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69590/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2018, 4:52 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Sergey > Urbanovich. > > > Bugs: MESOS-9492 > https://issues.apache.org/jira/browse/MESOS-9492 > > > Repository: mesos > > > Description > ------- > > This patch moves the CNI root directory to mesos working directory > so that the network related information persist across reboot which > will allow cni isolator to do proper cleanup post reboot > > > Diffs > ----- > > docs/cni.md 4a0e0bf57c6ff8d2bcc9fdf30d20672324da224c > docs/configuration/agent.md 7a8df6852dc2af174a6c5a552dca88fa1b1c29f3 > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > f19edce0671686bc2dccf5dc6d3abc40b925852e > src/slave/containerizer/mesos/isolators/network/cni/paths.hpp > 3b06fb101d03b32a3a148e2b79502413a7268d1e > src/slave/containerizer/mesos/isolators/network/cni/paths.cpp > c1cb4f7d667159abbf87219cde30528a4a7b5283 > src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 > src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 > src/tests/containerizer/cni_isolator_tests.cpp > 5473737cdc71a3179c22be0d4db2060a6ef53d24 > > > Diff: https://reviews.apache.org/r/69590/diff/4/ > > > Testing > ------- > > > Thanks, > > Deepak Goel > >
